file_get_contents performance

[Thor]

I am trying to debug/investigate/determine where the "drainage" is in my code.

I have a for each loop which uses

                  $json = file_get_contents($url);
                  $json = json_decode($json);

Would that be a such a big drain on performance or might it be the actual API url?

I tested my code block with this:

<?php

$startTime = microtime(true);

// my code

echo "Time:  " . number_format(( microtime(true) - $startTime), 4) . " Seconds\n";

?>

and well

The result is quite slow.

Between Time: 3.7666 Seconds and Time: 5.1338 Seconds

 

[[)roi(]]

Obviously if $url is remote; then it's out of your control.

The other thing to consider is how often the content that you're processing changes; if it's not realtime, then how about local caching the processed result (i.e. the result of your loop)?

 

[koeksGHT]

API url response time, just stick logic required in a cron script if it takes long to load.

 

[rward]

What are you trying to do?

 

[Thor]

Thanks for the responses so far.

What I am doing is this:

http://mybroadband.co.za/vb/showthread.php?t=834257

Basically I have a for each loop using the Bloomberg API to get the stock prices so currently it loads/runs everytime the page gets visited.

 

[koeksGHT]

Thanks for the responses so far.

What I am doing is this:

http://mybroadband.co.za/vb/showthread.php?t=834257

Basically I have a for each loop using the Bloomberg API to get the stock prices so currently it loads/runs everytime the page gets visited.

Run it on a cron every minute and insert into db.

 

[Thor]

So

$stocks array

For each stocks as stock

API url
www.api.com/$stock:jse

 

[koeksGHT]

I posted a reply with not even functioning code

 

[koeksGHT]

LOL!!!

Blocked again

 

[koeksGHT]

Here is paste of my reply that broke it

http://pastebin.com/mkBBcH22

 

[biometrics]

Thanks for the responses so far.

What I am doing is this:

http://mybroadband.co.za/vb/showthread.php?t=834257

Basically I have a for each loop using the Bloomberg API to get the stock prices so currently it loads/runs everytime the page gets visited.

Yeah that's terribly inefficient. Cron job + store in db is a better approach. If you don't want a cron job then add a timestamp to the db record and only fetch it every minute or so.

 

[Thor]

Yeah that's terribly inefficient. Cron job + store in db is a better approach. If you don't want a cron job then add a timestamp to the db record and only fetch it every minute or so.

Thats a new concept (cron jobs)

I'll need to study up ie how to actually write a cron job since I know what it is. Yea what your saying makes a lot more sense.

So poll the API for new prices every 5 minutes and then fetch the latest details from the dB everytime a user lands on the page?

I will send a image of my code in a moment. I'm on the phone.

 

[koeksGHT]

Thats a new concept (cron jobs)

I'll need to study up ie how to actually write a cron job since I know what it is. Yea what your saying makes a lot more sense.

So poll the API for new prices every 5 minutes and then fetch the latest details from the dB everytime a user lands on the page?

I will send a image of my code in a moment. I'm on the phone.

a cron is just a normal script file simply run from "crontab -e" with that bit in pastebin

 

[biometrics]

Thats a new concept (cron jobs)

I'll need to study up ie how to actually write a cron job since I know what it is. Yea what your saying makes a lot more sense.

So poll the API for new prices every 5 minutes and then fetch the latest details from the dB everytime a user lands on the page?

I will send a image of my code in a moment. I'm on the phone.

Cron job is one approach but not a must.

Probably easier for you going with my second suggestion, time stamp the db record and check how much time has passed and then refresh.

 

[koeksGHT]

Cron job is one approach but not a must.

Probably easier for you going with my second suggestion, time stamp the db record and check how much time has passed and then refresh.

It's nicer to cron and timestamp everything to make graphs

 

[Thor]

I appreciate the guidance I am going to make it open source when I'm done for now I am just trying to learn in the process.

This is my code.

 

[koeksGHT]

Just insert into db

mysql_query(INSERT INTO history (`stock`, `price`, `dateadded`) VALUES ($company, $price, NOW()));

Then on that page select from db and display

 

[biometrics]

It's nicer to cron and timestamp everything to make graphs

Sure, just considering Thor's experience. Easier doing the second approach for now.

 

[koeksGHT]

Sure, just considering Thor's experience. Easier doing the second approach for now.

So push him! Next week we will be on nosql and elastic search.

 

[Thor]

Just insert into db

mysql_query(INSERT INTO history (`stock`, `price`, `dateadded`) VALUES ($company, $price, NOW()));

Then on that page select from db and display

This looks very easy ie straightforward, just want to confirm when this actually happens.


Ie at the moment on my index page I have that code of mine as a php include so everytime a visitor lands on the page it will execute.

So when does the put it into a dB happen and how does the percentage changed gets displayed?

Although I guess the percentage changed can be added in the dB as well.

Thinking of this now a cron job seems perfect for this if the cron job updates the dB every 10 minutes and then visitors gets displayed the latest dB entries.

Am I looking at it correctly?