Code review isn’t evil

[Newsfeed]

Code review isn’t evil

 

[Johnatan56]

I love code review, allows all my/others mistakes to be pointed out so I can improve from my/their mistakes. Also allows problems to be tackled with different members of the team suggesting things, allowing one to more easily create a better solution, it saves a lot of time down the line.

Friend was at a company where it was extremely rare, he left quite quickly as he learnt nearly nothing there.

 

[krycor]

Friend was at a company where it was extremely rare, he left quite quickly as he learnt nearly nothing there.

Had people leave because they can’t handle being wrong or conforming to standard. Worse is when we see review comments not implemented and ends up on client deployment causing failures.

Instant way of being fired..

 

[Johnatan56]

Had people leave because they can’t handle being wrong or conforming to standard. Worse is when we see review comments not implemented and ends up on client deployment causing failures.

Instant way of being fired..

Good.

 

[ponder]

Opensource has code review coming out your yazoo. It's a very good model for peer review...

 

[/dev/null]

Me: Hey, I'm starting a bank and so I'm in search of software that will run my core banking operations. Can I look through the source code of your application to confirm that it doesn't do anything malicious that could jeopardise my bank and customers.

SAP: No, sorry. Code review is not allowed.

Me: F**k off.