Php noob help

[Thor]

snipped

I like that! I like that a lot. Thanks Kabal

OOP is something I really need to start doing, I am just struggling to think of things in a Object manner and before I know it I have a begin middle end approach.

 

[_kabal_]

no problem

a simple way is to try internalise the Single Responsibility Principal, and always ask yourself things like "Does this really belong here? What is this doing, is this a good name? etc"

 

[rward]

Extra S in the second one:

private static GET_ITEMS_SQL = "SELECT * FROM items";
private static GET_ITEMS_SQL = "SELECT * FROM items WHERE id = ?";

should be:

private static GET_ITEMS_SQL = "SELECT * FROM items";
private static GET_ITEM_SQL = "SELECT * FROM items WHERE id = ?";

 

[Thor]

no problem

a simple way is to try internalise the Single Responsibility Principal, and always ask yourself things like "Does this really belong here? What is this doing, is this a good name? etc"

I do do that and then I simply add it in a other file and use require or include

Right now I am trying to get comfortable with OOP and achieve "least privileged" since I can see from your example some variables and functions should not be accessible to anything other than the function that uses it.

 

[f0Iygu7gXHVM]

That's what I thought.

/moving on.

If this was production and not done in a few minutes of course I would do something like:

DELIMITER $$
 
CREATE PROCEDURE GetItem()
BEGIN
 SELECT *
 FROM items;
    END$$

and then

$sql = 'CALL GetItem()';

Why would you have completely different, insecure code in dev that will HAVE to change for it to be in production? Link some of your projects I'm (((interested)))

 

[_kabal_]

Extra S in the second one:

private static GET_ITEMS_SQL = "SELECT * FROM items";
private static GET_ITEMS_SQL = "SELECT * FROM items WHERE id = ?";

should be:

private static GET_ITEMS_SQL = "SELECT * FROM items";
private static GET_ITEM_SQL = "SELECT * FROM items WHERE id = ?";

via Imgflip Meme Generator

:crylaugh:

 

[Thor]

Why would you have completely different, insecure code in dev that will HAVE to change for it to be in production? Link some of your projects I'm (((interested)))

Because this was not a project this was an illustration to the OP of the logical process that must happen for him to display the data and was in no way more than this.

 

[Thor]

via Imgflip Meme Generator

:crylaugh:

Dead

Reps will come 2 U

 

[[)roi(]]

Because this was not a project this was an illustration to the OP of the logical process that must happen for him to display the data and was in no way more than this.

I think many miss that point; explanations are best kept simple.

 

[[)roi(]]

I like that! I like that a lot. Thanks Kabal

OOP is something I really need to start doing, I am just struggling to think of things in a Object manner and before I know it I have a begin middle end approach.

You should never fall into the quagmire of trying to envisage eveything as objects; that part of OOP is long considered BS. Design should be kept simple, don't ever build structure you'll probably never need.

 

[rward]

via Imgflip Meme Generator

:crylaugh:

It's like cloud9, but on steroids .. or something!

 

[_kabal_]

You should never fall into the quagmire of trying to envisage eveything as objects; that part of OOP is long considered BS. Design should be kept simple, don't ever build structure you'll probably never need.

this is true.

that is why I didnt go crazy and use a full blown service repository "pattern". all I wanted to do was create a simple abstraction/separation, to make things easier, in my mind, to understand, and potentially expand on if required

 

[Thor]

SQL injection FTW

You can try

$stmt = $pdo->prepare('SELECT * FROM items WHERE id = :id');

$stmt->execute(array('id' => $id));

foreach ($stmt as $row) {
    // do something with $row
}

 

[eternaloptimist]

I'm finding it hard to implement this...I think this because of the modal. my uri is http://localhost:8080/places.php#more when it pops up. I think I'll need some javascript to fix this?

 

[[)roi(]]

this is true.

that is why I didn't go crazy and use a full blown service repository "pattern". all I wanted to do was create a simple abstraction/separation, to make things easier, in my mind, to understand, and potentially expand on if required

Was a suggestion for Thor187; your code was spot on.

 

[Thor]

I'm finding it hard to implement this...I think this because of the modal. my uri is http://localhost:8080/places.php#more when it pops up. I think I'll need some javascript to fix this?

If you put it on github I will get it working for you.

 

[eternaloptimist]

This is what I have. The modal fires up properly but I can't get it to show clicked items data. If I include it the loop it shows data for the first item eg id 100's data for all the items clicked.
https://gist.github.com/anonymous/2905f524665e8809e0b8a66286e34023

 

[markbdaniels]

Why would you create a stored procedure for a simple select. I'd rather have it in code where it's more readable.

 

[Thor]

Why would you create a stored procedure for a simple select. I'd rather have it in code where it's more readable.

Oh do not bring that argument here, @Necropolis does not approve.

 

[Genisys]

Why even load that initial table from a DB (that table with the city names)? That is wasteful and should be discouraged. The more you read from the Database, the more resources will be needed. Use JSON and read the table content from the JSON file (just in case it will have to be modified) then use the modal to load the other stuff from the Database.