I want to roll a new char. Which one should it be, shaman or warlock and what levelling spec would be best with what professions? Any advice is welcome. tx
Shaman
All three specs are fun when I did mine, I mostly stay enhancement from 1-80 (elemental for pvp) then switched to resto from 80-85 and stayed like that since
There arnt really any levelling benefits to production professions. Skinning gives you crit, herbalism has a small heal, but not significant. Production professions provide benefits near their max skill level. Some raiding guilds will only you take you if have these professions.
As for the class, any class is lethal when played properly. You need to find the one you enjoy playing. Shaman has the advantage of being able to spec ad ranged dps or melee dps or healer, but at some point you need to settle on a main spec if you want to raid.
Personally, I prefer a warlock to shaman, but you should try both you have 10 character slots