I created an Android app. Please check out the code on Github

[Lebogang95]

I had a bit of time over the long weekend so I decided to create an Android app for the fun of it (When last). If you have time, please check it out and let me know what you think and/or suggest improvements where necessary.

It's a pretty basic app, it fetches and displays today's weather as well as the weather forecast for the next 5 days. For more information, you can have a look at the ReadMe that's included in the repo.

GitHub - lbnkosi/CleanWeather-Android: Android app which was developed using clean architecture principles. The application consumes REST APIs from OpenWeatherMap

Android app which was developed using clean architecture principles. The application consumes REST APIs from OpenWeatherMap - lbnkosi/CleanWeather-Android

github.com

 

[saor]

It's a pretty basic app, it fetches and displays the weather forecast for the next 5 days if I'm not mistaken.

Weird thing to say about an app you've developed.

 

[Lebogang95]

Weird thing to say about an app you've developed.

My reasoning for this and maybe I should have worded it better is that the API returns today's weather as part of the forecast. So I wasn't sure if whether I should put today's weather under the forecast or what. I display 6 results in the app, today's weather, and the weather forecast for the next 5 days.

 

[_kabal_]

hard to comment on code here, and not in a PR

some dont's IMO:

• the DM prefix in the domain folder is ugly and unneeded. just makes things more difficult to read
• private val mWeatherRepository: ITWeatherRepository
  • this should be IWeatherRepository, not IT prefix.​
  • not sure that "m" prefix is the standard anymore for android for member properties. I would refer to the Android + Kotlin style guide for this​
• "aIsOffline: Boolean," -> not a fan of this "a" prefix in method parameters

I can do a more detailed and in-depth review, not focusing solely on naming conventions, if you create a PR with specifics that you would like to review

 

[Lebogang95]

hard to comment on code here, and not in a PR

some dont's IMO:

• the DM prefix in the domain folder is ugly and unneeded. just makes things more difficult to read
• private val mWeatherRepository: ITWeatherRepository
  • this should be IWeatherRepository, not IT prefix.​
  • not sure that "m" prefix is the standard anymore for android for member properties. I would refer to the Android + Kotlin style guide for this​
• "aIsOffline: Boolean," -> not a fan of this "a" prefix in method parameters

I can do a more detailed and in-depth review, not focusing solely on naming conventions, if you create a PR with specifics that you would like to review

Thanks, I appreciate this. Would it be possible for you to create an issue on GitHub with the suggestions you have in mind?